Freeze version of workspace-client library #788
Conversation
vzhukovs
changed the title
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
vzhukovs
force-pushed
the
che#17246-freeze-ws-client
branch
from
6dcf3f3
to
105c8e0
Compare
|
it's not already frozen by yarn.lock ? |
In yarn.lock there is frozen latest version. I want to freeze specific version, because when eclipse-che/che-workspace-client#31 will be merged I want to be sure, that everything won't be broken. And... it's much easier for testing purposes, for testing new library version, it would be better to update version to the latest instead of pushing library to dedicate package and update imports in code. |
|
@benoitf is right. Tag |
|
This is temporary solution, which will be reverted with next PR today or afternoon. Because with next PR there will be an update of yarn.lock with fresh dependencies. Or we shouldn't worry, that some PRs will be merged today/afternoon with yarn.lock update? WDYT? |
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
I'm ok with that. |
|
I'm ok with all solutions, just wanted to emphasis that for now we're stuck to a given version even with 'latest' |
|
Yep, it will be reverted soon |
What does this PR do?
This changes proposal freezes version for workspace-client from
latestto latest tagged0.0.1-1585913592. To have smooth incoming changes that won't try to break anything after merge eclipse-che/che-workspace-client#31, because eclipse-che/che-workspace-client#31 is going to be merged among with upcoming changes in che-theia.Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com
What issues does this PR fix or reference?
Needed for eclipse-che/che#17246
Release Notes
N/A
Docs PR
N/A